Python bindings and tests for Triu #3637
Open
+110
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protonu
force-pushed
the
pbasu_triu_py_layer
branch
3 times, most recently
from
6ae6033 to
6d2e7ab
Compare
protonu
force-pushed
the
pbasu_iota_experiment
branch
from
260141f to
5f82c65
Compare
protonu
force-pushed
the
pbasu_triu_py_layer
branch
from
6d2e7ab to
a3ab248
Compare
protonu
force-pushed
the
pbasu_iota_experiment
branch
from
0b42b74 to
b734bf6
Compare
protonu
force-pushed
the
pbasu_triu_py_layer
branch
3 times, most recently
from
e134264 to
d66b838
Compare
|
!test |
protonu
changed the title
jacobhinkle
approved these changes
Jan 6, 2025
protonu
added a commit
that referenced
this pull request
Jan 6, 2025
This is a C++ API to implement `triu`. The PR (#3637) stacked on top of this used it to create a Python interface. Another way of using this may be to use the components of `triu` such as `iota`, `broadcast`, `le` and `where` from Thunder directly bypassing the need for a C++ implementation. As future work this commit/PR may be removed in favor of a Thunder only implementation.
protonu
force-pushed
the
pbasu_triu_py_layer
branch
from
1794bac to
0426b46
Compare
|
!test |
protonu
force-pushed
the
pbasu_triu_py_layer
branch
from
0426b46 to
8339c17
Compare
|
@jacobhinkle can you take another look? |
protonu
commented
Jan 7, 2025
| @@ -28,10 +28,13 @@ def parse_inputs_fusion_definition(fd: FusionDefinition, opinfo: OpInfo, *args): | |||
| ) | |||
|
|
|||
| num_symbolic_parameters = len(symbolic_parameter_list) | |||
| assert num_symbolic_parameters == len( | |||
| assert num_symbolic_parameters >= len( | |||
There was a problem hiding this comment.
@rdspring1 does this change look reasonable?
protonu
commented
Jan 7, 2025
| @@ -63,7 +63,9 @@ def parse_args_fusion_execution(opinfo: OpInfo, *args): | |||
| else [ArgumentType.Symbolic] * len(args) | |||
| ) | |||
|
|
|||
| assert len(symbolic_parameter_list) == len(args) | |||
| assert len(symbolic_parameter_list) >= len(args) | |||
There was a problem hiding this comment.
@rdspring1 does this change look okay? I had to make this change we could be generating args of different lengths.
jacobhinkle
approved these changes
Jan 7, 2025
Comment on lines
+35
to
+37
| if num_symbolic_parameters > len(args): | ||
| symbolic_parameter_list = symbolic_parameter_list[: len(args)] | ||
|
|
There was a problem hiding this comment.
I doubt this is necessary as zip will truncate to the length of the shortest argument.
rdspring1
reviewed
Jan 7, 2025
| }, | ||
| py::arg("input"), | ||
| py::arg("diagonal") = 0, | ||
| py::return_value_policy::reference); |
There was a problem hiding this comment.
Bonus points for adding a pytorch or numpy style docstring. It should go as the last argument in the def function.
Reference: https://pybind11.readthedocs.io/en/stable/advanced/misc.html#generating-documentation-using-sphinx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the Triu C++ API which was added in the PR (#3631)